Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using minio's mc client. #777

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Switch to using minio's mc client. #777

merged 4 commits into from
Apr 24, 2024

Conversation

presztak
Copy link
Collaborator

Fixes: #450

@presztak
Copy link
Collaborator Author

@stgraber, I'm not sure about runClientCommand method. Very similar implementation we have in subprocess package but I've needed to modify this a little bit to support change of working directory. mc admin cluster iam export creates file in current working directory so I think it would be better to have possibility to change CWD for any new file.

@presztak presztak marked this pull request as ready for review April 21, 2024 17:29
@presztak presztak requested a review from stgraber as a code owner April 21, 2024 17:29
@stgraber
Copy link
Member

Very good feedback from @gibmat, I'll let you sort those out!

I'm on vacation this week so I don't get to review things quite as quickly than usual but still usually get to process a couple PRs a day. I may get back to that one this evening or otherwise tomorrow morning.

Thanks!

@stgraber
Copy link
Member

stgraber@castiana:~/data/code/lxc/incus (735)$ ~/minio-binaries/mc --version
mc version RELEASE.2024-04-18T16-45-29Z (commit-id=3ec030eb26e460ec62655487ba116a05eda3ac99)
Runtime: go1.21.9 linux/amd64
Copyright (c) 2015-2024 MinIO, Inc.
License GNU AGPLv3 <https://www.gnu.org/licenses/agpl-3.0.html>

stgraber@castiana:~/data/code/lxc/incus (735)$ mc --version
GNU Midnight Commander 4.8.29
Built with GLib 2.74.5
Built with S-Lang 2.3.3 with terminfo database
Built with libssh2 1.10.0
With builtin Editor and Aspell support
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;
stgraber@castiana:~/data/code/lxc/incus (735)$ 

So probably look at the first line of output, if you get mc version that seems like it's going to be MinIO, if you get anything else, let's assume it's not.

@stgraber
Copy link
Member

LGTM, thanks!

@stgraber stgraber merged commit dc504d8 into lxc:main Apr 24, 2024
25 checks passed
adamcstephens added a commit to adamcstephens/nixpkgs that referenced this pull request Apr 27, 2024
I manually audited all `RunCommand` and `exec.LookPath` calls in the incus repo, combined with the following information

/run/wrappers/bin
lxc usable-cub 20240427123718.368 WARN     idmap_utils - ../src/lxc/idmap_utils.c:lxc_map_ids:165 - newuidmap binary is missing

iw
lxc 20240427123830.358 ERROR    network - ../src/lxc/network.c:lxc_netdev_move_wlan:1679 - Couldn't find the application iw in PATH

minio-client
lxc/incus#777

ceph-client
Added, but could be missing bits to actually work
May need full ceph package for `radosgw-admin` for object storage?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using minio's mc client
3 participants