Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizable columns to incus profile list #803

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

amroKerkizz
Copy link

Implemented code to help add customizable columns. Issue for reference is #720.

amro kerkiz and others added 4 commits April 29, 2024 13:33
@stgraber
Copy link
Member

Did a quick review and fixes on this one, I had to do:

  • Fix commit message to include sign-off and bug being closed
  • Run gofmt -s -w ./ and notice that the code doesn't even compile...
  • Fix the code (missing bracket at end of for loop)
  • Run gofmt -s -w ./
  • Fixed the default column layout in help message
  • Ran make i18n to generate the needed translation commit
  • Ran make static-analysis and fixed the issues it identified

I also picked up a small issue with the help message of the incus project list command which had been done earlier, so pushed a fix for that in this one too.

@stgraber stgraber merged commit 352466c into lxc:main Apr 29, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants