Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incusd/network/ovn/nb: Port more NAT functions #812

Merged
merged 2 commits into from
May 3, 2024
Merged

incusd/network/ovn/nb: Port more NAT functions #812

merged 2 commits into from
May 3, 2024

Conversation

Abhiram824
Copy link
Contributor

No description provided.

@Abhiram824
Copy link
Contributor Author

Abhiram824 commented May 1, 2024 •
edited
Loading

I'm doing a nested loop in DeleteLogicalRouterDNATSNAT, not sure if this is the best approach

@stgraber stgraber changed the title incusd/network/ovn/nb: ported another nat function incusd/network/ovn/nb: Port more NAT functions May 2, 2024
@stgraber stgraber marked this pull request as ready for review May 2, 2024 19:29
@stgraber stgraber self-requested a review as a code owner May 2, 2024 19:29
@stgraber
Copy link
Member

stgraber commented May 2, 2024

Did a few edits:

  • Turned everything into a single DeleteLogicalRouterNAT function which takes the type (snat/dnat_and_snat) as well as a boolean to indicate if it should flush everything and an optional list of IPs (for when the boolean is false).
  • Removed the old functions
  • Ported the callers to the new functions

@stgraber stgraber merged commit 85b0562 into lxc:main May 3, 2024
25 checks passed
@Abhiram824 Abhiram824 mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhiram824 @stgraber