Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for all-projects for networks, network-acls, and storage buckets #838

Merged
merged 26 commits into from
May 6, 2024
Merged

Add support for all-projects for networks, network-acls, and storage buckets #838

merged 26 commits into from
May 6, 2024

Conversation

sona78
Copy link
Contributor

@sona78 sona78 commented May 5, 2024 •
edited by stgraber
Loading

Closes #713, #715, #716

@sona78 sona78 requested a review from stgraber as a code owner May 5, 2024 21:30
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels May 5, 2024
@stgraber
Copy link
Member

stgraber commented May 6, 2024

Looking into this one now

@stgraber
Copy link
Member

stgraber commented May 6, 2024

Did the following:

  • Restructured the commit list
  • Fixed storage bucket API extension not being at end of the list
  • Fixed missing API extension in shared/api
  • Added translation template
  • Added missing swagger data for networks and network acls
  • Removed LXD references from client/
  • Ran make static-analysis and fixed what it found
  • Fixed all-projects FormValue retrieval
  • Added missing argument to GetStoragePoolBucketsAllProjects
  • Fixed calls to missing functions (tx.GetNetworksAllProjects and tx.GetNetworkACLsAllProjects)
  • Bunch of other cleanups and fixes

@stgraber stgraber changed the title Added support for all-projects for networks, network-acls, and storage buckets Add support for all-projects for networks, network-acls, and storage buckets May 6, 2024
sona78 and others added 13 commits May 6, 2024 14:53
@sona78 @stgraber
api: network_acls_all_projects
43e9674 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
shared/api: Add Project field to NetworkACL
a46bc65 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
client: Add GetNetworkACLsAllProjects
b6df3b4 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
incus/network/acl: Add all-projects
ef41416 
Signed-off-by: sona78 <[email protected]>
@stgraber
incusd/db: Add GetNetworkACLsAllProjects
b1b1fa4 
Signed-off-by: Stéphane Graber <[email protected]>
@stgraber
incusd/network/acl: Set Project field
18a4964 
Signed-off-by: Stéphane Graber <[email protected]>
@sona78 @stgraber
incusd/network_acls: Add all-projects
988cce7 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
api: storage_buckets_all_projects
0a48523 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
shared/api: Add Project field to StorageBucket
68feadb 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
client: Add GetStoragePoolBucketsAllProjects
b4e4cce 
Signed-off-by: sona78 <[email protected]>
@sona78 @stgraber
incus/storage/bucket: Add all-projects
58dce75 
Signed-off-by: sona78 <[email protected]>
@stgraber
incusd/db/storage_buckets: Fill Project field
39c0d53 
Signed-off-by: Stéphane Graber <[email protected]>
@sona78 @stgraber
incusd/storage_buckets: Add all-projects
68e5713 
Signed-off-by: sona78 <[email protected]>
@stgraber stgraber merged commit 1733379 into lxc:main May 6, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add all-projects support for network acls
2 participants
@sona78 @stgraber