Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port LogicalRouterSNATAdd and LogicalRouterDNATSNATAdd #840

Merged
merged 2 commits into from
May 6, 2024
Merged

Port LogicalRouterSNATAdd and LogicalRouterDNATSNATAdd #840

merged 2 commits into from
May 6, 2024

Conversation

DhruvNistala
Copy link
Contributor

No description provided.

@stgraber
Copy link
Member

stgraber commented May 6, 2024

Processing this one now

@stgraber
Copy link
Member

stgraber commented May 6, 2024

I did:

  • Rebased the commits together
  • Separated the internal/server/network/driver_ovn.go changes
  • Added Signed-off-by
  • Fixed build failures
  • Fixed function description

@stgraber stgraber marked this pull request as ready for review May 6, 2024 15:14
@stgraber stgraber self-requested a review as a code owner May 6, 2024 15:14
@stgraber stgraber merged commit 20b2a64 into lxc:main May 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DhruvNistala @stgraber