Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable columns network list functionality #848

Merged
merged 2 commits into from
May 7, 2024

Conversation

sharkman424
Copy link
Contributor

closes Add customizable columns to incus network list #719
signed off by: Joshua Dierker [email protected]

@sharkman424 sharkman424 requested a review from stgraber as a code owner May 6, 2024 21:54
@sharkman424
Copy link
Contributor Author

i am unable to run make static-analysis at the moment. Shellcheck is giving an error despite being installed
image

@stgraber
Copy link
Member

stgraber commented May 7, 2024

Looking into this one, I did:

  • Rebase on main
  • Reworded the commits a bit
  • Ran make static-analysis and fixed the couple of issues it identified

@stgraber stgraber changed the title closes #719: added customizable columns network list functionality Addcustomizable columns network list functionality May 7, 2024
@stgraber stgraber force-pushed the main branch 3 times, most recently from adc01e5 to f4317a4 Compare May 7, 2024 02:46
@stgraber stgraber changed the title Addcustomizable columns network list functionality Add customizable columns network list functionality May 7, 2024
sharkman424 and others added 2 commits May 6, 2024 22:57
@stgraber stgraber merged commit e54aa49 into lxc:main May 7, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants