Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bugfixes #889

Merged
merged 7 commits into from
May 23, 2024
Merged

Various bugfixes #889

merged 7 commits into from
May 23, 2024

Conversation

stgraber
Copy link
Member

No description provided.

hallyn
hallyn reviewed May 23, 2024
View reviewed changes
shared/idmap/shift_linux.go Outdated Show resolved Hide resolved
hallyn
hallyn requested changes May 23, 2024
View reviewed changes
Copy link
Member

@hallyn hallyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(looks good otherwise)

@stgraber
incusd/apparmor/lxc: Fix rule syntax
d2c13e3 
Closes lxc#886

Signed-off-by: Stéphane Graber <[email protected]>
@stgraber
Copy link
Member Author

Added close calls to the write error handling path, that should do it.

@stgraber stgraber force-pushed the main branch 2 times, most recently from 52cb2b7 to 4ea60f5 Compare May 23, 2024 13:18
hallyn
hallyn reviewed May 23, 2024
View reviewed changes
shared/idmap/shift_linux.go Outdated Show resolved Hide resolved
@hallyn hallyn merged commit 1315976 into lxc:main May 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn hallyn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stgraber @hallyn