Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN Update #3

Closed
arb opened this issue Sep 10, 2015 · 4 comments
Closed

NaN Update #3

arb opened this issue Sep 10, 2015 · 4 comments

Comments

@arb
Copy link

arb commented Sep 10, 2015

Consider updating to NaN 2.x.x to support Node 4.

For an example of the required changes, check out this diff.
@lxe
Copy link
Owner

lxe commented Sep 10, 2015

Upgrading won't help... NaN changed drastically in version 2. I need to rewrite the binding code (again). What's the point of NaN if it keeps changing as often as the node API?

@arb
Copy link
Author

arb commented Sep 10, 2015

Excellent question.

@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@kkoopa
Copy link

kkoopa commented Sep 10, 2015

The point is backwards compatibility.

@arb arb mentioned this issue Sep 20, 2015
Closed
@arb arb closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChALkeR @lxe @arb @kkoopa