Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

good-console test not compatible with v4 #52

Closed
lloydbenson opened this issue Sep 15, 2015 · 2 comments
Closed

good-console test not compatible with v4 #52

lloydbenson opened this issue Sep 15, 2015 · 2 comments
Assignees
@arb
Labels
bug Bug or defect
Milestone
5.1.0

Comments

@lloydbenson
Copy link
Contributor

good-console won't test with node v4. I'd recommend removing the "stand-in" module as a dependency.
@arb
Copy link
Contributor

arb commented Sep 20, 2015

Yeah the issue is stand-in uses obj-hash which doesn't work in v4 yet either. See related issue lxe/node-objhash#3. I think stand-in might get updated to avoid obj-hash.

@arb arb added the bug Bug or defect label Sep 20, 2015
@arb arb self-assigned this Sep 20, 2015
@arb arb added this to the 5.1.0 milestone Sep 21, 2015
@arb arb closed this as completed in 084da74 Sep 21, 2015
lloydbenson added a commit that referenced this issue Sep 21, 2015
@lloydbenson
Merge pull request #53 from arb/node4
3c60a14 
Fixes node 4 issue. Closes #52.
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arb arb

Labels
bug Bug or defect
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@lloydbenson @arb