Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning mouse cursor in ftp or smb dialog #1263

Open
stefonarch opened this issue Dec 20, 2020 · 7 comments
Open

Spinning mouse cursor in ftp or smb dialog #1263

stefonarch opened this issue Dec 20, 2020 · 7 comments
Labels

Comments

@stefonarch
Copy link
Member

Not a big issue but during authentication all clicks have to be performed with a spinning cursor, also ok buttons and so on.

  • Distribution & Version: all & all
    schermata-20-12-22:08
@tsujan
Copy link
Member

tsujan commented Dec 20, 2020

That's intentional. When the loading is started, the code changes the cursor to Qt::WaitCursor in the whole application.

@tsujan tsujan closed this as completed Dec 20, 2020
@tsujan
Copy link
Member

tsujan commented Dec 20, 2020

Or maybe, we could make an exception for the dialog somehow. Reopening to investigate...

@tsujan
Copy link
Member

tsujan commented Dec 21, 2020

Unfortunately, it isn't possible. The reason:

The signal Fm::Folder::startLoading is never caught on entering a directory because it's sent from the constructor of Fm::Folder. If we wait for that signal to show the busy cursor, it won't be shown at all. Therefore, we need to show the busy cursor as soon as we start to enter a directory. The password dialog is shown after that and it belongs to the app (pcmanfm-qt); hence the busy cursor over it.

EDIT: Actually, it isn't impossible. The busy cursor can be removed once the dialog is shown and resumed after it but the needed changes will clutter the code for such a small case.

@tsujan tsujan closed this as completed Dec 21, 2020
@stefonarch
Copy link
Member Author

Thanks anyway for your efforts!

@tsujan
Copy link
Member

tsujan commented Dec 23, 2020

Sorry for closing and opening this twice!

I've had second thoughts about it: it's a UX problem — although a minor one — and is worth a fix. When the dialog is shown, there's no need to the busy cursor, to say nothing of its interfering with the possible cursor shapes inside the dialog.

Let's try to find the shortest way of fixing it...

@tsujan tsujan reopened this Dec 23, 2020
@tsujan tsujan added the later label Dec 23, 2020
@stefonarch
Copy link
Member Author

No need to be sorry ;)

No idea about the code, but if there can be a check over which type of window the cursor is and change it accordingly, maybe with a little delay?

@tsujan
Copy link
Member

tsujan commented Dec 23, 2020

Unfortunately, since the cursor is changed application-wise (and it should be changed so), it can't be overridden by specific windows/widgets.

The solution is restoring the usual cursor for the whole application as soon as that dialog is shown and changing it to the busy cursor when the dialog is closed. That's possible in two ways: inside pcmanfm-qt's code or inside libfm-qt's code. A third way may be possible too. I just want to find the shortest way with the smallest amount of code.

I reopened the issue after trying SMB and seeing how weird that busy cursor was over the dialog ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants