-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLs in markdown code blocks being incorrectly checked #117
Comments
Th following is also "correctly" caught as a broken link. |
Just realised I have created this PR on the Lychee repo, but I am seeing this with the Lychee Action. |
Code blocks only get excluded when setting the |
Oh, maybe I misunderstood the discussion on You're saying that including things verbatim actually then excludes some things (such as code blocks)? From your comment: lycheeverse/lychee#523 (comment)
Which is what I actually would like, but that doesn't seem to be happening. I had thought this was already the default case as I have the action running correctly on another project which I think does this OK (though I can't recall if there are any links in code blocks in that project). |
Sorry for the confusion, my bad. What I meant was that the newest version of lychee already excludes code blocks by default, so no need to do anything. 😅 |
Thanks that's what I expected. |
The lychee version of lychee-action is not up to date. I need to release a new version first. |
This continues to check code blocks. It was the previous behaviour, but changed in lychee. The v1.5.0 lychee action has an updated lychee, which now supports and enforces this flag now. See lycheeverse/lychee-action#116 and lycheeverse/lychee-action#117.
This checks links in code blocks. It was the previous default lychee behaviour by default, but recently changed. So we need to enable this to continue these checks, as we've now updated the lychee action (#758). See lycheeverse/lychee-action#116 and lycheeverse/lychee-action#117.
The PR lycheeverse/lychee#523 seems to indicate that code blocks in markdown will be ignored.
However this is not happening when I add this action in a workflow here: git-ecosystem/git-credential-manager#700
For example the
localhost
orcontoso
links are reported as failures. Those examples use fenced code block, indent code block, and inline code markdown formatting. Per these examples:Have I done something wrong?
The text was updated successfully, but these errors were encountered: