Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typos #173

wants to merge 2 commits into from

Conversation

lishaduck
Copy link

Just some minor clean up.

lydell added a commit that referenced this pull request Jul 11, 2024
@@ -4,7 +4,7 @@
"license": "MIT",
"author": "Simon Lydell",
"repository": "lydell/eslint-plugin-simple-import-sort",
"description": "Easy autofixable import sorting",
"description": "Easy, autofixable import sorting",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a very trustworthy source called ChatGPT 🙃 for advice on this:

Both can be correct because they convey slightly different nuances:

  1. “Easy, autofixable import sorting”: The comma separates "easy" and "autofixable," suggesting that the import sorting is both easy and autofixable as two distinct qualities.

  2. “Easy autofixable import sorting”: Without the comma, "easy" and "autofixable" work together as a single phrase to describe the import sorting, implying that the process of making imports autofixable is easy.

While the comma adds a slight pause, both forms are grammatically correct and convey a similar overall meaning. The choice depends on whether you want to emphasize the qualities separately or together.

I’m not a native English speaker, so I can’t tell what’s right.

Either way, if we should go with the comma, we should make the same change in the readme.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ChatGPT is right about that.
I would've said it was both easy (as in it makes sense) and autofixable, but it could also be easily autofixable, in which case its fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants