Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PythonVirtualenvOperator when using provide_context=True (#8256) #229

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

ArgentFalcon
Copy link

@ArgentFalcon ArgentFalcon commented Sep 3, 2020

apache#8256

This change will ensure that provide_context=True works on v1.10.12 for PythonVirtualenvOperator

Clean up code and simplified the solution to ignore just the unserializable items
adding pytest for PythonVirtualenvOperator

…8256)

This change will ensure that provide_context=True works on v1.10.12 for PythonVirtualenvOperator

Clean up code and simplified the solution to ignore just the unserializable items
adding pytest for PythonVirtualenvOperator
@ArgentFalcon
Copy link
Author

cc @lyft/dpe-airflow

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #229 into airflowinfra will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           airflowinfra     #229      +/-   ##
================================================
- Coverage         27.79%   27.79%   -0.01%     
================================================
  Files               528      528              
  Lines             36622    36625       +3     
================================================
  Hits              10179    10179              
- Misses            26443    26446       +3     
Impacted Files Coverage Δ
airflow/operators/python_operator.py 31.21% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2999a99...50b31ab. Read the comment docs.

@astahlman
Copy link

👍

Looks like this won't actually unblock the user though. If ti isn't supported then we can't pull xcoms, right?

@ArgentFalcon
Copy link
Author

Yeah. I'm working with him on that. Might as well merge this anyways though.

@ArgentFalcon
Copy link
Author

💨

@ArgentFalcon ArgentFalcon merged commit 2eb4c1e into airflowinfra Sep 3, 2020
@eschachar eschachar deleted the pythonvirtualenv_fix branch September 24, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants