Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4453] Make behavior of none_failed consistent with documentation (#7464) #235

Merged
merged 2 commits into from
Nov 18, 2020

Commits on Nov 17, 2020

  1. [AIRFLOW-4453] Make behavior of none_failed consistent with documen…

    …tation (apache#7464)
    
    The documentation for the `none_failed` trigger rule
    (https://airflow.apache.org/docs/stable/concepts.html#trigger-rules)
    describes its behavior as "all parents have not failed (`failed` or
    `upstream_failed`) i.e. all parents have succeeded or been skipped."
    With that definition in mind, there is no reason that the check for
    `none_failed` should ever have to check for skipped upstream tasks or
    set the current task to `skipped`. The current behavior causes the rule
    to skip if all upstream tasks have skipped, which is more than a little
    confusing. This fixes the behavior to be consistent with the documentation.
    
    Co-authored-by: root <[email protected]>
    2 people authored and ArgentFalcon committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    d5cd589 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Fix tests

    ArgentFalcon committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    545d8ae View commit details
    Browse the repository at this point in the history