-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display non essential tf commands #108
Do not display non essential tf commands #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the one comment I had!
// No need to write to projectOutputBuffers if clear msg. | ||
if line == models.LogStreamingClearMsg { | ||
return | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to write ClearMsg to the projectOutputBuffers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted it
/ptal @nishkrishnan @Aayyush |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
* Do not display non essential tf commands * Add title with correct tabbing * fix ui issues * more fixes
* Do not display non essential tf commands * Add title with correct tabbing * fix ui issues * more fixes
No description provided.