Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display non essential tf commands #108

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

msarvar
Copy link

@msarvar msarvar commented Sep 16, 2021

No description provided.

nishkrishnan
nishkrishnan previously approved these changes Sep 16, 2021
Aayyush
Aayyush previously approved these changes Sep 16, 2021
Copy link

@Aayyush Aayyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one comment I had!

Comment on lines 170 to 174
// No need to write to projectOutputBuffers if clear msg.
if line == models.LogStreamingClearMsg {
return
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to write ClearMsg to the projectOutputBuffers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it

@msarvar
Copy link
Author

msarvar commented Sep 16, 2021

/ptal @nishkrishnan @Aayyush

Copy link

@Aayyush Aayyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msarvar
Copy link
Author

msarvar commented Sep 16, 2021

/merge

@msarvar msarvar merged commit 86e42d0 into release-v0.17.1-lyft.1 Sep 16, 2021
@msarvar msarvar deleted the remove-unnecessary-log-message branch September 16, 2021 19:08
msarvar added a commit that referenced this pull request Sep 27, 2021
* Do not display non essential tf commands

* Add title with correct tabbing

* fix ui issues

* more fixes
Aayyush pushed a commit that referenced this pull request Dec 9, 2021
* Do not display non essential tf commands

* Add title with correct tabbing

* fix ui issues

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants