Post implementation for gateway #201
Conversation
| case models.OpenedPullEvent, models.UpdatedPullEvent: | ||
| // If the pull request was opened or updated, we perform a pseudo-autoplan to determine if tf changes exist. | ||
| // If it exists, then we will forward request to the worker. | ||
| go g.handleOpenPullEvent(baseRepo, headRepo, pull, user, request) |
There was a problem hiding this comment.
Let's just run this synchronously? Will be easier to see failure states. Previously it's asynchronous to prevent long lived connections but since we're just publishing to a queue we can remove this level of indirection.
There was a problem hiding this comment.
Maintaining async with timer for now and will followup with move to sync processing if we find it's not expensive
| PullUpdater *events.PullUpdater | ||
| } | ||
|
|
||
| func (r *AutoplanValidatorBuilder) IsValid(baseRepo models.Repo, headRepo models.Repo, pull models.PullRequest, user models.User) bool { |
There was a problem hiding this comment.
ValidatorBuilder 🤯 lol, how bout just validator?
| timer := r.Scope.Timer(metrics.ExecutionTimeMetric).Start() | ||
| defer timer.Stop() |
There was a problem hiding this comment.
can we move the instrumentation into a separate function? Otherwise it's large number of duplicate error calls.
| return false | ||
| } | ||
| if r.DisableAutoplan { | ||
| r.Scope.Counter(metrics.ExecutionErrorMetric).Inc(1) |
There was a problem hiding this comment.
This is weird to me, it shouldn't be an error because a flag is set. Let's remove this, we don't even use this code path anyways.
Implements VCSPostHandler to create Gateway's version of GH event handling. It duplicates a lot of the logic/testing from the existing
VCSEventsControllerworkflow, but is different because pull request events that don't need processing (i.e. have no terraform changes) are returned immediately while requests that do are sent through SNS to the worker.This is an alternate implementation to #191. We avoid having to modify existing CommandRunner interfaces with this approach.