Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context object to update status structs. #224

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

nishkrishnan
Copy link
Contributor

Idea here is to eventually have Context everywhere which allows us to use the k/v store that's part of it to pass middleware metadata around.

Basically I don't want us to necessarily have to pass our logger around everywhere just to have the same request scope. We should be able to pass in things like repo name, pull num, request id, through the context and initialize a new logger wherever we need.

Motivation for adding this came from needing the logger with request id in the gh client for logging status updates.

@nishkrishnan nishkrishnan merged commit 56d841d into release-v0.17.3-lyft.1 Mar 29, 2022
@nishkrishnan nishkrishnan deleted the nish/thread-ctx-status branch March 29, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants