Add new Logger interface and update vcs client. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
previously approved these changes
Mar 30, 2022
samrabelachew
previously approved these changes
Mar 30, 2022
nishkrishnan
dismissed stale reviews from samrabelachew and msarvar
via
ec83a9b
samrabelachew
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new
Loggerinterface to be used for all our logging going forward. This supports the standard structured logging functions in addition to context value extraction.This Logger is basically pinned to the exported interfaces defined in https://github.com/logur/logur, which is an opinionated logging library that's wildly popular in the go space.
I made the conscious decision here to also remove the formatting functions from our logger as we should move towards using structured logging for everything.
The new logger should play nicely with temporal's logging system as our previous one didn't.
Finally, I removed the error logging in the github client and added debug logs around the successes. Error logging should only really happen at the highest level the error gets propagated to. I modifed the
UpdateStatuslogging to be info level since we've been seeing issues there recently.