Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limit publisher nil pointer deref. #87

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

nishkrishnan
Copy link
Contributor

Was using the wrong client as input to the executor service so as part of this change I moved the logic inside the atlantis github client for consistency.

Additionally, I modified the ticker logic to solve the following:

  • Old logic would potentially run parallel go routines if the routine took longer than the ticker duration (not super useful)
  • panics would crash the entire server; this is now isolated to a given job on the executor service
  • properly making use of context cancelling to shut down child threads.

@nishkrishnan nishkrishnan merged commit 70e040a into release-v0.17.1-lyft.1 Jul 6, 2021
@nishkrishnan nishkrishnan deleted the nish/fix-rate-limit-publisher branch July 6, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant