Skip to content

Commit

Permalink
Revert "Revert "remove skips""
Browse files Browse the repository at this point in the history
This reverts commit 2845963.
  • Loading branch information
sethsaperstein-lyft committed May 4, 2023
1 parent 25b4859 commit 8781624
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 19 deletions.
4 changes: 0 additions & 4 deletions integ/blue_green_deployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import (
)

func WaitForUpdate(c *C, s *IntegSuite, name string, updateFn func(app *v1beta1.FlinkApplication), phase v1beta1.FlinkApplicationPhase, failurePhase v1beta1.FlinkApplicationPhase) *v1beta1.FlinkApplication {
c.Skip("local")

// update with new image.
app, err := s.Util.Update(name, updateFn)
c.Assert(err, IsNil)
Expand All @@ -34,8 +32,6 @@ func WaitForUpdate(c *C, s *IntegSuite, name string, updateFn func(app *v1beta1.
}

func (s *IntegSuite) TestUpdateWithBlueGreenDeploymentMode(c *C) {
c.Skip("local")

log.Info("Starting test TestUpdateWithBlueGreenDeploymentMode")

testName := "bluegreenupdate"
Expand Down
5 changes: 0 additions & 5 deletions integ/checkpoint_failure_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ func failingJobTest(s *IntegSuite, c *C, testName string, causeFailure func()) {

// Tests that we correctly handle updating a job with a checkpoint timeout
func (s *IntegSuite) TestCheckpointTimeout(c *C) {
c.Skip("local")

log.Info("Starting test TestCheckpointTimeout")

failingJobTest(s, c, "checkpointtimeout", func() {
Expand Down Expand Up @@ -156,7 +154,6 @@ func failingTaskTest(s *IntegSuite, c *C, testName string, fallbackWithoutState

// Tests that we correctly handle updating a job with task failures
func (s *IntegSuite) TestJobWithTaskFailures(c *C) {

log.Info("Starting test TestJobWithTaskFailures")
failingTaskTest(s, c, "taskfailure", false, true, func() {
err := s.Util.ExecuteCommand("minikube", "ssh", "touch /tmp/checkpoints/fail && chmod 0644 /tmp/checkpoints/fail")
Expand All @@ -166,8 +163,6 @@ func (s *IntegSuite) TestJobWithTaskFailures(c *C) {
}

func (s *IntegSuite) TestSavepointCheckpointFailureFallback(c *C) {
c.Skip("local")

log.Info("Starting test TestSavepointCheckpointFailureFallback")
failingTaskTest(s, c, "recoveryfallback", true, false, func() {
err := s.Util.ExecuteCommand("minikube", "ssh", "touch /tmp/checkpoints/fail && chmod 0644 /tmp/checkpoints/fail")
Expand Down
6 changes: 0 additions & 6 deletions integ/job_cancellation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ func WaitUpdateAndValidate(c *C, s *IntegSuite, name string, updateFn func(app *

// tests the workflow of job cancellation without savepoint
func (s *IntegSuite) TestJobCancellationWithoutSavepoint(c *C) {
c.Skip("local")

log.Info("Starting test TestJobCancellationWithoutSavepoint")
testName := "cancelsuccess"
const finalizer = "simple.finalizers.test.com"
Expand Down Expand Up @@ -139,8 +137,6 @@ func (s *IntegSuite) TestJobCancellationWithoutSavepoint(c *C) {
// tests a job update with the existing job already in cancelled state.
// here, the new submitted job starts without a savepoint.
func (s *IntegSuite) TestCancelledJobWithoutSavepoint(c *C) {
c.Skip("local")

log.Info("Starting test TestCancelledJobWithoutSavepoint")

testName := "invalidcancel"
Expand Down Expand Up @@ -217,8 +213,6 @@ func (s *IntegSuite) TestCancelledJobWithoutSavepoint(c *C) {

// tests the recovery workflow of the job when savepoint is disabled.
func (s *IntegSuite) TestJobRecoveryWithoutSavepoint(c *C) {
c.Skip("local")

log.Info("Starting test TestJobRecoveryWithoutSavepoint")

const finalizer = "simple.finalizers.test.com"
Expand Down
4 changes: 0 additions & 4 deletions integ/simple_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ func updateAndValidate(c *C, s *IntegSuite, name string, updateFn func(app *v1be

// Tests job submission, upgrade, rollback, and deletion
func (s *IntegSuite) TestSimple(c *C) {
c.Skip("local")

log.Info("Starting test TestSimple")

const finalizer = "simple.finalizers.test.com"
Expand Down Expand Up @@ -268,8 +266,6 @@ func (s *IntegSuite) TestSimple(c *C) {
}

func (s *IntegSuite) TestRecovery(c *C) {
c.Skip("local")

log.Info("Starting test TestRecovery")

config, err := s.Util.ReadFlinkApplication("test_app.yaml")
Expand Down

0 comments on commit 8781624

Please sign in to comment.