[STRMCMP-569] Failures during job startup should trigger immediate rollback #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
glaksh100
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user specifies a wrong entry class or the main method throws an exception, the Flink API returns back a 500 error with a
org.apache.flink.client.program.ProgramInvocationException.In order to minimize downtime, we want to rollback immediately in this case rather than waiting for retries to be exhausted.
This PR also improves the error reporting a bit for this situation. Previously, the error wrapping functions took an array of strings which were reported verbatim. This produced confusing output that implied that the API itself was returning an array. As all actual calls to these methods were using either 0 or 1 arguments, I've split it out into those particular cases.