Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep config names constant across error_handler and config #101

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Keep config names constant across error_handler and config #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/flink/client/error_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ type RetryHandlerInterface interface {
// A Retryer that has methods to determine if an error is retryable and also does exponential backoff
type RetryHandler struct {
baseBackOffDuration time.Duration
maxErrWaitDuration time.Duration
maxErrDuration time.Duration
maxBackOffMillisDuration time.Duration
}

Expand Down Expand Up @@ -95,7 +95,7 @@ func (r RetryHandler) IsRetryRemaining(err error, retryCount int32) bool {

func (r RetryHandler) WaitOnError(clock clock.Clock, lastUpdatedTime time.Time) (time.Duration, bool) {
elapsedTime := clock.Since(lastUpdatedTime)
return elapsedTime, elapsedTime <= r.maxErrWaitDuration
return elapsedTime, elapsedTime <= r.maxErrDuration

}
func (r RetryHandler) GetRetryDelay(retryCount int32) time.Duration {
Expand Down