[STRMCMP-661] Fix bug that could lead to multiple job submission #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
anandswaminathan
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that could lead to multiple jobs being submitted during the SubmittingJob phase. This would happen if a job was failing during the deploy process; because the activeJobs filter was excluding failing jobs, the operator would think that there was no job running and would resubmit another.
I've also taken this opportunity to make the operator more opinionated about which job it's managing in the cluster. Whereas previously we would query for all jobs in the cluster and take the first "active" one, we now rely on the jobId we've stored in our state to determine which is our job.
If this changes somehow from underneath us (like if the user cancels the job through the API and submits a new job) we should not continue on as if everything is well, as future operations are likely to fail or lead to unexpected outcomes anyways.