[STRMCMP-639] Trigger immediate rollback when job submission fails #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
pkg/controller/flink/client/api.go
Outdated
| @@ -231,7 +231,11 @@ func (c *FlinkJobManagerClient) SubmitJob(ctx context.Context, url string, jarID | |||
| // Flink returns a 500 when the entry class doesn't exist or crashes on start, but we want to fail fast | |||
| // in those cases | |||
| body := response.String() | |||
| if strings.Contains(body, "org.apache.flink.client.program.ProgramInvocationException") { | |||
| // ProgramInvocationException is thrown when the entry class doesn't exist or throws an exception | |||
| if strings.Contains(body, "org.apache.flink.client.program.ProgramInvocationException") || | |||
There was a problem hiding this comment.
Nit: Can you move "org.apache.flink.client.program.ProgramInvocationException" to a const err variable ?
anandswaminathan
previously approved these changes
Oct 9, 2019
anandswaminathan
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another case to our immediate rollback (i.e., unretryable error) logic, that catches the case where the job submission fails. This typically happens due to an incompatible savepoint or an invalid jobgraph.