Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added finalizer permissions #12

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

yuchaoran2011
Copy link
Contributor

  1. I tried out the project and found out an issue with starting a Flink app:
time="2019-06-03T18:10:48Z" level=error msg="Jobmanager deployment creation failed deployments.apps \"wordcount-operator-example-f5b2ddb2-jm\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: no RBAC policy matched, <nil>" app_name=wordcount-operator-example ns=flink-operator phase=

The reason is that the finalizer permissions were not properly given to the ClusterRole. This PR fixed it. (Note: I'm on OpenShift. Not sure if it's OpenShift-specific but this change shouldn't break non-OpenShift k8s).

  1. Added some notes about resource requirements when deploying the operator. I wasn't able to deploy initially because of lack of resources. I think it's better to let the user know that the default requirements might not be what he wants.

@anandswaminathan
Copy link
Contributor

Thanks for fixing. Merging this to master.

@anandswaminathan anandswaminathan merged commit 5dbd1bd into lyft:master Jun 3, 2019
@yuchaoran2011 yuchaoran2011 deleted the finalizer branch June 10, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants