Remove old flink-app-hash selector from generic service #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
|
Looks good. Want to add a unit test. Very hard to catch if someone removes this. |
|
It's actually fine if this gets removed in the future. It's only needed immediately after upgrading the operator from pre-#209. |
anandswaminathan
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#209 changed how we associate pods with services; previously we used the
flink-app-hashlabel, but in order to decouple hashes from deployments this was changed to the randompod-deployment-selector.For versioned services, this change did not cause any issues, as new versioned services are created for each deploy. The generic (non-versioned) service, however is kept for the lifetime of an application and so needs to be "upgraded" to the new way of selecting pods. #209 included support for upgrading existing services by adding the
pod-deployment-selectorlabel. However, it did not remove the existingflink-app-hashlabel. This broke generic services for applications that had been deployed on a previous version of the operator.This PR fixes that, by removing the flink-app-hash label during the deploy process.