Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EventRecorder instead of emitting events manually #36

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Use EventRecorder instead of emitting events manually #36

merged 1 commit into from
Jun 27, 2019

Conversation

anandswaminathan
Copy link
Contributor

This replaces the current implementation of creating events manually through the Client.

  Type    Reason  Age   From              Message
  ----    ------  ----  ----              -------
  Normal  Create  32s   flinkK8sOperator  Flink cluster created
  Normal  Create  20s   flinkK8sOperator  Flink job submitted to cluster with id 519428ccbadc58365924f1bba55324b1
  Normal  Update  14s   flinkK8sOperator  Flink cluster created
  Type    Reason  Age   From              Message
  ----    ------  ----  ----              -------
  Normal  Create  34s   flinkK8sOperator  Flink cluster created
  Normal  Create  22s   flinkK8sOperator  Flink job submitted to cluster with id 519428ccbadc58365924f1bba55324b1
  Normal  Update  16s   flinkK8sOperator  Flink cluster created```

mwylde
mwylde approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a huge improvement.

@anandswaminathan anandswaminathan merged commit 6d92339 into master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwylde mwylde mwylde approved these changes

@glaksh100 glaksh100 Awaiting requested review from glaksh100

@kumare3 kumare3 Awaiting requested review from kumare3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandswaminathan @mwylde