Update logic around number and healthy task managers in status #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
requested review from
glaksh100,
kumare3 and
mwylde
as code owners
mwylde
approved these changes
Jun 27, 2019
glaksh100
reviewed
Jun 27, 2019
| application.Status.ClusterStatus.Health = v1alpha1.Red | ||
| return false, errors.New(clusterErrors) | ||
| } else if application.Status.ClusterStatus.HealthyTaskManagers == application.Status.ClusterStatus.NumberOfTaskManagers { | ||
| if application.Status.ClusterStatus.HealthyTaskManagers == tmDeployment.Status.Replicas { |
glaksh100
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Logic:
NumberOfTaskManagersHealthyTaskManagersis still obtained from the API responseHealthyTaskManagers, and number of replicas expected.Cluster status is also updated when in
SubmittingJobstate.Not updating the ClusterStatus in
ClusterStarting, as there could be multiple clusters, and hence removed the check.