Add support for non restored state on job submission

[YuvalItzchakov]

This PR adds support for providing the --allowNonRestoredState flag to a submit job request. If, for some reason, that state isn't persistent between versions of a job, the deployment will fail entirely.

The addition here adds a allowNonRestoredState boolean flag to the crd.yaml.

[anandswaminathan]

Add to test that this field is populated.
https://github.com/lyft/flinkk8soperator/blob/master/pkg/controller/flink/flink_test.go#L432

[anandswaminathan]

Also you need to run make generate

[YuvalItzchakov]

@anandswaminathan Appended a check to the existing test, created a new test to make sure appendNonRestoredState is propagated properly when set and ran make generate

[anandswaminathan]

Great. Thanks @YuvalItzchakov

Merging it. You can always use the image on the master - docker.io/lyft/flinkk8soperator:{SHA} and not wait for a release version.

[anandswaminathan]

@YuvalItzchakov This is not the right way to do it.

You will have to plumb the flag through the state machine. This case will not work when there is a rollback scenario.

Check this: https://github.com/lyft/flinkk8soperator/blob/master/pkg/controller/flinkapplication/flink_state_machine.go#L266

You will need to add the flag to the status as well - https://github.com/lyft/flinkk8soperator/blob/master/pkg/controller/flinkapplication/flink_state_machine.go#L366

[YuvalItzchakov]

Thanks @anandswaminathan, I’ll get to work on the fix.