Upgrade controller runtime and Multi Namespace support for Flink operator #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
requested review from
glaksh100,
kumare3 and
mwylde
as code owners
anandswaminathan
commented
Jul 2, 2019
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "github.com/lyft/flytestdlib" | ||
| version = "0.2.8" | ||
| revision = "4e4da2f1ca1745127a79d299ef9048e86bd4e44c" |
There was a problem hiding this comment.
To be updated once I merge flytestdlib changes and generate a release
|
It's not clear to me why this PR (which seems limited to internal details of the operator) should cause a hash change. Can you expand on what's going on there? |
|
@mwylde The version of Controller Runtime that supports MultiNamespace, has constraint to use an upgraded version of "k8s.io/api" - this updates the underlying Deployment/Container/PodTemplate spec object. Few I found:
|
mwylde
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backward Incompatible]
The hash value computation has changed. Deploying this version of operator will cause rollover/restart of applications.
This PR upgrades the version of controller runtime. Uses a fixed version of Flytestdlib.
Flink operator will now support watching applications across multiple namespaces, previously it was either a single namespace or all namespaces.