Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the correct deployments for readiness and status checks #42

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

mwylde
Copy link
Contributor

@mwylde mwylde commented Jul 9, 2019

We somehow ended up with two codepaths for finding the current deployments associated with an application. The one used by the status checks was using the current application hash, not the DeployHash, to find the deployments.. This caused it to fail for applications that had been rolled back with error logs like

ERRO[0000] Unable to find task manager deployment        app_name=operator-test-app ns=default phase=DeployFailed src="flink.go:461"

This PR removes that function and moves the callers to GetCurrentDeploymentsForApp, which also has the benefit of making the handling code a bit simpler.

Also cleans up duplicate codepaths for finding app deployments
@anandswaminathan
Copy link
Contributor

+1

I see the issue, it is this check that was missing

	if appHash == app.Status.FailedDeployHash {
		return app.Status.DeployHash
	}

@mwylde
Copy link
Contributor Author

mwylde commented Jul 10, 2019

Yeah, that's what was missing. If we've failed to deploy, the current hash is the DeployHash, not Hash(app).

@mwylde mwylde merged commit 4297702 into master Jul 10, 2019
@mwylde mwylde deleted the micah_find_right_deployments branch July 10, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants