Find the correct deployments for readiness and status checks #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We somehow ended up with two codepaths for finding the current deployments associated with an application. The one used by the status checks was using the current application hash, not the DeployHash, to find the deployments.. This caused it to fail for applications that had been rolled back with error logs like
This PR removes that function and moves the callers to
GetCurrentDeploymentsForApp
, which also has the benefit of making the handling code a bit simpler.