Add a ForceRollback option to CRD #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaksh100
requested review from
anandswaminathan,
kumare3 and
mwylde
as code owners
glaksh100
changed the title
|
cc. @mwylde / @anandswaminathan |
glaksh100
changed the title
|
Updates based on discussion (captured here)
cc @anandswaminathan / @mwylde |
mwylde
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a user to cancel an ongoing deploy/update. This is done in the following way:
CancelDeployto the Spec. The user sets this to be True to cancel the deploy.CancelDeployis set to True,shouldRollbackevaluates to True and moves the application to aDeployFailedstate.CancelDeployto False enables the deploy to be continued (as would be the case when we fix forward from DeployFailed)simple_test.shfor this workflow.CancelDeployAlternatively, I could have added an extra state (like
DeployCancelled) but felt that that would have been quite a bit of code duplication as it'd be very similar to the DeployFailed state. Happy to incorporate other ideas!