[Backward Incompatible] Modifying Hash function to be consistent #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
requested review from
glaksh100,
kumare3 and
mwylde
as code owners
|
This change makes the hash sensitive to the order of fields in the json output, which are not guaranteed to be consistent across versions of the json library or go (Java 8 for example changed its hashmap implementation, which caused fields to get re-ordered compared to java 7). Ideally we'd find a solution that is insensitive to details of the map or json implementations, while still handling missing fields correctly. |
|
@mwylde Updated to use Object hash - https://github.com/benlaurie/objecthash |
mwylde
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever we upgrade "client-go", "apimachinery", "api" the hash value also changes.
This PR changes the hashing mechanism
I have tested this across these two SHAs -
9aaa992bf12ecd0577a4b0f7dfb1c248a93d47eaandf9206646aaffb7763657ec9e794bc979b0b4722b. The hash does not change.