Add node selectors to job and task config #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annymsMthd
requested review from
anandswaminathan,
kumare3 and
mwylde
as code owners
|
Looks like the |
|
@annymsMthd Just merged to master a PR to remove docker_hub push from PRs. |
annymsMthd
force-pushed
the
feature/add-node-selectors-to-job-and-task
branch
from
e6b22f2
to
a5e5f36
Compare
anandswaminathan
requested changes
Jun 3, 2019
annymsMthd
force-pushed
the
feature/add-node-selectors-to-job-and-task
branch
from
a5e5f36
to
28b6690
Compare
Signed-off-by: Joshua Benjamin <[email protected]>
annymsMthd
force-pushed
the
feature/add-node-selectors-to-job-and-task
branch
from
28b6690
to
acfda60
Compare
|
@anandswaminathan should be gtg now |
|
Hey Joshua — can you give a bit more context on why this is needed? |
|
Sure thing. In our kubernetes cluster we have different labels for nodes. Since we self host we have dedicated nodes for certain workloads. e.g. ingress, worker, storage, etc. |
|
@mwylde @anandswaminathan any reason not to move forward with this? This is a pretty common thing in k8s. |
mwylde
approved these changes
Jun 7, 2019
anandswaminathan
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Benjamin [email protected]