Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete verb for service #8

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Add delete verb for service #8

merged 2 commits into from
Jun 4, 2019

Conversation

annymsMthd
Copy link
Contributor

Signed-off-by: Joshua Benjamin [email protected]

@annymsMthd
Copy link
Contributor Author

Delete verb is required when operator deletes a cluster

time="2019-06-03T00:14:10Z" level=info msg="Logged Normal event: Update: Deleting old cluster with hash e06c5ae7" app_name=vehicle-health-pipeline ns=default phase=DeployFailed
time="2019-06-03T00:14:10Z" level=warning msg="Failed to delete versioned service" app_name=vehicle-health-pipeline ns=default phase=DeployFailed
time="2019-06-03T00:14:10Z" level=warning msg="Failed to reconcile resource default/vehicle-health-pipeline: services \"vehicle-health-pipeline-e06c5ae7\" is forbidden: User \"system:serviceaccount:flink-operator:flinkoperator\" cannot delete resource \"services\" in API group \"\" in the namespace \"default\"" app_name=vehicle-health-pipeline ns=default phase=DeployFailed

@annymsMthd
Add delete verb for service
786598b 
Signed-off-by: Joshua Benjamin <[email protected]>
anandswaminathan
anandswaminathan approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@anandswaminathan anandswaminathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this to master. Thanks for submitting.

deploy/role.yaml
@@ -22,6 +22,7 @@ rules:
- get
- list
- watch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching. Can you add ‘update’ as well.

@anandswaminathan anandswaminathan merged commit 75f04e5 into lyft:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandswaminathan anandswaminathan anandswaminathan approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3

@mwylde mwylde Awaiting requested review from mwylde

@glaksh100 glaksh100 Awaiting requested review from glaksh100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annymsMthd @anandswaminathan