[STRMCMP-616] Use error retrying system for savepoint errors during deletion #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
| @@ -676,6 +677,8 @@ func (s *FlinkStateMachine) handleApplicationDeleting(ctx context.Context, app * | |||
| fmt.Sprintf("Failed to take savepoint %v", status.Operation.FailureCause)) | |||
| // clear the trigger id so that we can try again | |||
| app.Spec.SavepointInfo.TriggerID = "" | |||
| return true, client.GetRetryableError(errors.New("failed to take savepoint"), | |||
There was a problem hiding this comment.
Add a unit test ?
anandswaminathan
previously approved these changes
Aug 22, 2019
added 2 commits
August 22, 2019 15:17
|
Updated with unit test and a config change to increase the maximum retry delay when running integration tests. This reduces the number of log lines in the integration test by ~1k. |
anandswaminathan
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a flinkapplication is being deleted with
DeleteMode: Savepointand the savepoint operation is failing, we will retry endlessly with no delay on the savepoint operation. This is because in that case, we don't return an error back to the error management system of the state machine.This PR fixes that by properly returning an error for that situation. This causes us to do retry with exponential backoff instead of on every statemachine iteration.
It also should fix the "exceeded the maximum log length" integration test failures, which are caused by endless logging of the retries.