fix(378): ensure that undefined executions ids won't get into graph #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
ursucarina,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 66.45% 66.43% -0.02%
==========================================
Files 405 405
Lines 9059 9063 +4
Branches 1599 1600 +1
==========================================
+ Hits 6020 6021 +1
- Misses 3039 3042 +3
Continue to review full report at Codecov.
|
olga-union
reviewed
Apr 14, 2022
olga-union
reviewed
Apr 14, 2022
Signed-off-by: Nastya Rusina <[email protected]>
flyte-bot
added a commit
that referenced
this pull request
Apr 14, 2022
# [0.52.0](http://github.com/lyft/flyteconsole/compare/v0.51.3...v0.52.0) (2022-04-14) ### Bug Fixes * **378:** ensure that undefined executions ids won't get into graph ([#388](http://github.com/lyft/flyteconsole/issues/388)) ([ea9d2b3](http://github.com/lyft/flyteconsole/commit/ea9d2b31e1e6f51872eb7d10283b645de3b17bec)) ### Features * cleanup ([#389](http://github.com/lyft/flyteconsole/issues/389)) ([05b88ed](http://github.com/lyft/flyteconsole/commit/05b88ed2d2ecdb5d8a8404efea25414e57189709))
|
🎉 This PR is included in version 0.52.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current fix removed request for undefined executionIds, which usually happens with branch nodes.
It allows us to avoid unneeded crash. Further work is needed for proper support of Branch nodes.
Type
Are all requirements met?
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/378
Follow-up issue
This fix currently removes the crash, however it doesn't fix the branch node representation, which is still a bit off. A separate task was created to cover that work:
https://github.com/flyteorg/flyteconsole/issues/377
TODOwith task number was added to the code to ensure, that fix would be fully testedSigned-off-by: Nastya Rusina [email protected]