Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from apache/lyft-release-sp8 #24

Merged
merged 1 commit into from
May 1, 2019

Conversation

DiggidyDave
Copy link

Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415)

  • add stronger type hints where possible

  • fix: lint issues and add select_star func in Hive

  • add missing pkg init

  • fix: build issues

  • fix: pylint issues

  • fix: use logging instead of print

…ase-sp8) (apache#7415)

* add stronger type hints where possible

* fix: lint issues and add select_star func in Hive

* add missing pkg init

* fix: build issues

* fix: pylint issues

* fix: use logging instead of print
@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #24 into lyft-develop will decrease coverage by <.01%.
The diff coverage is 74.19%.

Impacted file tree graph

@@               Coverage Diff               @@
##           lyft-develop     #24      +/-   ##
===============================================
- Coverage            65%     65%   -0.01%     
===============================================
  Files               429     429              
  Lines             21081   21095      +14     
  Branches           2337    2337              
===============================================
+ Hits              13704   13712       +8     
- Misses             7253    7259       +6     
  Partials            124     124
Impacted Files Coverage Δ
superset/models/sql_types/presto_sql_types.py 72.41% <66.66%> (-11.8%) ⬇️
superset/db_engine_specs.py 60.22% <81.25%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd685e...51c7f92. Read the comment docs.

@DiggidyDave DiggidyDave merged commit d244588 into lyft-develop May 1, 2019
@DiggidyDave DiggidyDave deleted the mergeLatestFromApache branch August 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants