Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest from lyft-release-sp8 #26

Merged
merged 4 commits into from
May 3, 2019
Merged

Conversation

DiggidyDave
Copy link

feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)

betodealmeida and others added 4 commits May 3, 2019 14:25
* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing
* Lightweight pipelines POC

* Add docs

* Minor fixes

* Remove Lyft URL

* Use enum

* Minor fix

* Fix unit tests

* Mark props as required
feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)
@codecov-io
Copy link

codecov-io commented May 3, 2019

Codecov Report

Merging #26 into lyft-develop will decrease coverage by 0.03%.
The diff coverage is 52%.

Impacted file tree graph

@@               Coverage Diff                @@
##           lyft-develop      #26      +/-   ##
================================================
- Coverage            65%   64.96%   -0.04%     
================================================
  Files               429      430       +1     
  Lines             21095    21164      +69     
  Branches           2337     2342       +5     
================================================
+ Hits              13712    13750      +38     
- Misses             7259     7290      +31     
  Partials            124      124
Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.jsx 91.01% <ø> (ø) ⬆️
.../assets/src/SqlLab/components/QueryAutoRefresh.jsx 11.9% <0%> (-0.92%) ⬇️
superset/views/sql_lab.py 94.64% <100%> (ø) ⬆️
superset/assets/src/featureFlags.ts 88.88% <100%> (+13.88%) ⬆️
...sets/src/SqlLab/components/ScheduleQueryButton.jsx 13.33% <13.33%> (ø)
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 59.8% <50%> (-0.2%) ⬇️
superset/db_engine_specs.py 61.45% <86.11%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d244588...eec6419. Read the comment docs.

@DiggidyDave DiggidyDave merged commit 3117b1a into lyft-develop May 3, 2019
@DiggidyDave DiggidyDave deleted the mergeLatest branch May 3, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants