Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets path to fix admin entity editing #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pluies
Copy link
Contributor

@Pluies Pluies commented Jan 16, 2023

Hey folks,

I was trying to get entity editing to work as per the README under Gateway Admin UI), but the page at https://<presto-gateway>/entity/ ended up broken. I realised that CSS / JS resources weren't loading because the template references assets via relative path, and the admin page is located at /entity. The relative path therefore ends up being /entity/assets/... which receives a 404.

The attached PR fixes this by setting an absolute path for /assets, rather than relative.

(Note: I assume that this is the correct thing to do, but I'm not 100% sure as the docs don't actually specify the URL for the admin page - maybe I'm just using the wrong path? Please let me know if that's the case :) )

@akhurana001
Copy link
Contributor

akhurana001 commented Apr 10, 2023

So /entity works fine for me and I can see css files loading fine without this change.

Can you share screenshots to help us understand/replicate what's broken ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants