add stats handler #218
Merged
add stats handler #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuvedverma
force-pushed
the
add-stats-handler
branch
from
da0eb30
to
4627c2e
Compare
anuvedverma
force-pushed
the
add-stats-handler
branch
from
4627c2e
to
2cd95fe
Compare
|
/ptal @riteshvaryani @theevocater Very rough attempt at adding |
premsantosh
reviewed
Jul 3, 2024
| StatisticsHandler stats = this.server.getChildHandlerByClass(StatisticsHandler.class); | ||
| this.scheduler.scheduleAtFixedRate(() -> { | ||
| log.debug("(jetty) Num requests: " + stats.getRequests()); | ||
| log.debug("(jetty) Num requests: " + stats.getRequestsActive()); |
There was a problem hiding this comment.
ah thanks-- fixed it on the sev-16337-add-header-logging branch
|
wait i'm confused -- is the goal here to actually collect these metrics or just log them to stdout? wouldn't it be better to just output this via the statsd collector we already have? |
|
@theevocater doing this via statsd collector would probably be much better, but I'm honestly not sure how to do it... I see that we use statsd collector in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.