Add the possibility to change key mapping #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not over yet. I need to change the array of chords and bass because they aren't in the right order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like this project, and I think that it would be cool to be able to change the key mapping.
For people that don't use QWERTY keyboards, it can be frustrating to play with the controls. So I made it possible to change them.
I tried to keep the UI basic and in coherence with the application.
It's also possible to remap multiple bass/chords to one key. So that you can play multiple sounds by just pressing one key.
I don't know if it's a good idea tho.
Hoping that the changes are coherent.