Disable logging by default in Configuration.cs
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `GeneralSettings.DisableLogging` with `GeneralSettings.EnableLogging` and set it to `false` in `Configuration.cs` - Map it manually on startup to avoid dotnet/runtime#89732 This should avoid the issue of the binary being dependent on `appsettings.json`, unless logging is required
eduherminio
force-pushed
the
dissable-logging-by-default-in-source-configuration-file
branch
from
1dd51b6
to
461106e
Compare
eduherminio
deleted the
dissable-logging-by-default-in-source-configuration-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeneralSettings.DisableLoggingwithGeneralSettings.EnableLoggingand set it tofalseinConfiguration.csThis should avoid the issue of the binary crashing without
appsettings.json.This doesn't mean it should be used without it, it will swallow all errors and arnings, but yeah, you can.
appsettings.jsonareConfiguration.csare sync'edappsettingsvalues to Config ones