Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Clamp static evaluation within +- checkmate limits #510

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Nov 19, 2023

This avoids engine crashes for positions such as:
QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QPPPPPPP/K6k b - - 0 1
and engine crashes such as
https://lichess.org/49dBqSDK

position fen QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QPPPPPPP/K6k b - - 0 1 moves h1g1
go depth 50
info depth 1 seldepth 1 multipv 1 score mate 138 nodes 1 nps 1 time 20 pv
info depth 1 seldepth 1 multipv 1 score mate 138 nodes 1 nps 1 time 27 hashfull 0 pv
bestmove a8a8

Non-regression tests:

8+0.08 👍🏽

Score of Lynx-bugfix-staticeval-out-of-range-1977-win-x64 vs Lynx 1.0.0: 2105 - 2033 - 2741  [0.505] 6879
...      Lynx-bugfix-staticeval-out-of-range-1977-win-x64 playing White: 1415 - 666 - 1359  [0.609] 3440
...      Lynx-bugfix-staticeval-out-of-range-1977-win-x64 playing Black: 690 - 1367 - 1382  [0.402] 3439
...      White vs Black: 2782 - 1356 - 2741  [0.604] 6879
Elo difference: 3.6 +/- 6.4, LOS: 86.8 %, DrawRatio: 39.8 %
SPRT: llr 2.91 (100.6%), lbound -2.25, ubound 2.89 - H1 was accepted

40+0.4, had to cancel

Score of Lynx-bugfix-staticeval-out-of-range-1977-win-x64 vs Lynx 1.0.0: 2105 - 2033 - 2741  [0.505] 6879
...      Lynx-bugfix-staticeval-out-of-range-1977-win-x64 playing White: 1415 - 666 - 1359  [0.609] 3440
...      Lynx-bugfix-staticeval-out-of-range-1977-win-x64 playing Black: 690 - 1367 - 1382  [0.402] 3439
...      White vs Black: 2782 - 1356 - 2741  [0.604] 6879
Elo difference: 3.6 +/- 6.4, LOS: 86.8 %, DrawRatio: 39.8 %
SPRT: llr 2.91 (100.6%), lbound -2.25, ubound 2.89 - H1 was accepted

This avoids engine crashes for positions such as:
`QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QQQQQQQQ/QPPPPPPP/K6k b - - 0 1`
@eduherminio eduherminio marked this pull request as ready for review November 20, 2023 09:27
@eduherminio eduherminio merged commit bcacef3 into main Nov 20, 2023
21 checks passed
@eduherminio eduherminio deleted the bugfix/staticeval-out-of-range branch November 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant