Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Move eval params to its own class and make all of them static readonly #911

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Aug 12, 2024

This supersedes #907

Test  | eval/params-separated-class-2
Elo   | 2.35 +- 4.22 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 2.93 (-2.25, 2.89) [-5.00, 0.00]
Games | 11848: +3550 -3470 =4828
Penta | [317, 1332, 2599, 1306, 370]
https://openbench.lynx-chess.com/test/588/

@eduherminio eduherminio marked this pull request as ready for review August 12, 2024 19:37
@eduherminio eduherminio merged commit 3e87e0a into main Aug 12, 2024
27 checks passed
@eduherminio eduherminio deleted the eval/params-separated-class-2 branch August 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant