Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #731 #887,修复桌面歌词与主窗口阴影残留 #1869

Merged
merged 5 commits into from
Apr 28, 2024

Conversation

zclorne
Copy link
Contributor

@zclorne zclorne commented Apr 28, 2024

@lyswhut 你好,根据electron的说法,这个bug仅出现在mac的透明窗口中。桌面台词窗口就是这种窗口,该修复在mac下取消了该窗口的阴影效果。相较于invalidShadow()这种延迟清理的做法,直接取消阴影效果感觉更舒服。对于主窗口采取了同样的方案。
以下是修改后的效果:
lx-rx
桌面歌词不会有阴影残留了,感觉还不错。
SCR-20240428-ooyb
主窗口虽然取消了阴影,可能macos会自动为窗体创建阴影,依然有阴影效果。
修改后不影响其他系统用户。

@lyswhut
Copy link
Owner

lyswhut commented Apr 28, 2024

我之前没注意到electron提供了这个选项,而且是这个选项在MacOS上导致出现残留阴影的罪魁祸首,事实上程序并不需要系统绘制窗口阴影,程序自己实现了窗口阴影,这应该就是你取消了窗口阴影仍然正常工作的原因,感谢你的PR ❤️,我晚点抽空再做些修改彻底解决这个问题😀

@zclorne
Copy link
Contributor Author

zclorne commented Apr 28, 2024

非常感谢您的辛苦付出❤️

@lyswhut lyswhut merged commit 05363a0 into lyswhut:dev Apr 28, 2024
1 check passed
@washmore
Copy link

大赞,困扰很久的问题终于解决啦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants