Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump websocket-extensions from 0.1.3 to 0.1.4 #453

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 5, 2020

Bumps websocket-extensions from 0.1.3 to 0.1.4. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Regular Expression Denial of Service in websocket-extensions (NPM package)

Impact

The ReDoS flaw allows an attacker to exhaust the server's capacity to process incoming requests by sending a WebSocket handshake request containing a header of the following form:

Sec-WebSocket-Extensions: a; b="\c\c\c\c\c\c\c\c\c\c ...

That is, a header containing an unclosed string parameter value whose content is a repeating two-byte sequence of a backslash and some other character. The parser takes exponential time to reject this header as invalid, and this will block the processing of any other work on the same thread. Thus if you are running a single-threaded server, such a request can render your service completely unavailable.

Patches

Users should upgrade to version 0.1.4.

Workarounds

... (truncated)

Affected versions: < 0.1.4

Changelog

Sourced from websocket-extensions's changelog.

0.1.4 / 2020-06-02

  • Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)
  • Change license from MIT to Apache 2.0
Commits
  • 8efd0cd Bump version to 0.1.4
  • 3dad4ad Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser
  • 4a76c75 Add Node versions 13 and 14 on Travis
  • 44a677a Formatting change: {...} should have spaces inside the braces
  • f6c50ab Let npm reformat package.json
  • 2d211f3 Change markdown formatting of docs.
  • 0b62083 Update Travis target versions.
  • 729a465 Switch license to Apache 2.0.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@bdffa3b). Click here to learn what that means.
The diff coverage is 89.35%.

❗ Current head 602fc0f differs from pull request most recent head b0b4ce6. Consider uploading reports for the commit b0b4ce6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #453   +/-   ##
==========================================
  Coverage           ?   90.79%           
==========================================
  Files              ?      118           
  Lines              ?     2215           
  Branches           ?      661           
==========================================
  Hits               ?     2011           
  Misses             ?      204           
  Partials           ?        0           
Impacted Files Coverage Δ
.../manual-trigger/register-manual-trigger-watcher.js 100.00% <ø> (ø)
...play-conditions/scroll/register-element-watcher.js 0.00% <0.00%> (ø)
src/rollup/utils/persist/erase.js 0.00% <0.00%> (ø)
src/rollup/utils/utils.js 100.00% <ø> (ø)
src/rollup/utils/get-scrolling-element.js 6.66% <6.66%> (ø)
src/rollup/data/tracking/track-widget-action.js 88.00% <50.00%> (ø)
...display-conditions/exit-intent/init-exit-intent.js 73.68% <73.68%> (ø)
src/rollup/validation/validate-widget-position.js 84.21% <75.00%> (ø)
src/rollup/widgets/show-widget.js 75.75% <81.81%> (ø)
src/rollup/recommendations/recommend-content.js 73.91% <93.75%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdffa3b...b0b4ce6. Read the comment docs.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/websocket-extensions-0.1.4 branch from 48955b0 to 895f743 Compare June 12, 2020 00:35
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/websocket-extensions-0.1.4 branch 2 times, most recently from 2e8fa23 to 602fc0f Compare March 18, 2021 17:10
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/websocket-extensions-0.1.4 branch from 602fc0f to b0b4ce6 Compare July 9, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants