Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete coverage of Alertmanager packages #28

Merged
merged 8 commits into from
May 3, 2019
Merged

Complete coverage of Alertmanager packages #28

merged 8 commits into from
May 3, 2019

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Apr 30, 2019 •
edited by gfr10598
Loading

This change completes unit test coverage of the alertmanager packages.

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 104

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.3%) to 100.0%
Totals Coverage Status
Change from base Build 97: 9.3%
Covered Lines: 290
Relevant Lines: 290
💛 - Coveralls

pboothe
pboothe approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit b98ff0e into master May 3, 2019
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-increase-coverage branch August 12, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboothe pboothe pboothe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @pboothe