Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify configuration in README #51

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Clarify configuration in README #51

merged 1 commit into from
Jan 29, 2021

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jan 29, 2021 •
edited by gfr10598
Loading

This change adds new configuration hints based on feedback from #50

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 147: 0.0%
Covered Lines: 408
Relevant Lines: 408
💛 - Coveralls

nkinkade
nkinkade approved these changes Jan 29, 2021
View reviewed changes
Copy link

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit e75a71b into master Jan 29, 2021
@stephen-soltesz stephen-soltesz deleted the stephen-soltesz-patch-1 branch August 12, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkinkade nkinkade nkinkade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @nkinkade