-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/make docker image smaller #55
Feature/make docker image smaller #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @aorfanos -- thank you for your contributions! I have a few clarifying questions and small requests.
Reviewable status: 0 of 1 LGTMs obtained
Dockerfile, line 8 at r1 (raw file):
ADD . ./ # TODO(soltesz): Use vgo for dependencies.
If you're making some edits, please remove this TODO. It predates go mod
.
Dockerfile, line 12 at r1 (raw file):
-w -s -extldflags '-static'
Can you say why these are necessary now?
Dockerfile, line 15 at r1 (raw file):
./cmd/github_receiver FROM gcr.io/distroless/static
Please add this link as a comment above FROM
.
# See also: https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md
I found this to confirm that the TLS certificates were part of this "distroless" image. Initially I briefly confused with this and FROM scratch
.
hey @stephen-soltesz , happy to contribute to such an amazing project :) Regarding this:
The flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 LGTMs obtained
Changes:
Size reduction ~45% (43.49%) from 28.51MB to 16.11MB.
This change is